search

protonemedia / laravel-ffmpeg

This package provides an integration with FFmpeg for Laravel. Laravel's Filesystem handles the storage of the files.
https://protone.media/en/blog/how-to-use-ffmpeg-in-your-laravel-projects
MIT License
1.63k stars 194 forks source link

PHP deprecated: getDurationInMiliseconds() and getDurationInSeconds() #427

Closed ignacio-dev closed 1 year ago

ignacio-dev commented 2 years ago

When using getDurationInMiliseconds() and getDurationInSeconds() PHP throws this message:

PHP Deprecated: Implicit conversion from float 10983.333 to int loses precision

francoism90 commented 2 years ago

I think it should be using float, instead of int. See #429

ibrainventures commented 2 years ago

i changed with my pr https://github.com/protonemedia/laravel-ffmpeg/pull/403/files so .. there is no silence :-)

pascalbaljet commented 1 year ago

Fixed in v8.2.0