protonemedia / laravel-ffmpeg

This package provides an integration with FFmpeg for Laravel. Laravel's Filesystem handles the storage of the files.
https://protone.media/en/blog/how-to-use-ffmpeg-in-your-laravel-projects
MIT License
1.63k stars 194 forks source link

Bug fix #466

Open SadeghPM opened 1 year ago

SadeghPM commented 1 year ago

When set disk on construct function we must return class instance.

aronquiray commented 1 year ago

I think it's not necessary to add a return statement in the construct method in Laravel. The construct method is automatically called when an object is created from a class, and its purpose is to initialize the properties of the object. It's common to set up dependencies or perform other setup tasks in the __construct method, but the method does not require a return statement because its purpose is to modify the object itself, rather than returning a value.

SadeghPM commented 1 year ago

@aronquiray ok but think what is the purpose of $disk in construct? if we don't return class instance, $disk is useless.