protonemedia / laravel-ffmpeg

This package provides an integration with FFmpeg for Laravel. Laravel's Filesystem handles the storage of the files.
https://protone.media/en/blog/how-to-use-ffmpeg-in-your-laravel-projects
MIT License
1.67k stars 194 forks source link

[Question] Cleanup temporary files #524

Open cristiansoftlead opened 3 months ago

cristiansoftlead commented 3 months ago

Hello,

I try to use cleanupTemporaryFiles() but it doesn't work. I have a job that runs in the background using workers and I tried to put this method inside onProgress ( there is no documentation how to use it ).

$ffmpeg->onProgress(function ($percent) {
            $this->video->hls_progress = $percent;
            $this->video->save();

            if((int)$percent === 100) {
                try {
                    FFMpeg::cleanupTemporaryFiles();
                } catch(\Exception) {}
            }
        });

But this isn't working....the temporary files are still there. Should I just chain this method here, like this, and he will know to delete temp files only after everything is done?

$ffmpeg = FFMpeg::fromDisk('s3')
            ->open($this->video->url)
            ->exportForHLS()
            ->toDisk('s3')
            ->cleanupTemporaryFiles();

Thank you