search

protonemedia / laravel-splade

💫 The magic of Inertia.js with the simplicity of Blade 💫 - Splade provides a super easy way to build Single Page Applications (SPA) using standard Laravel Blade templates, and sparkle it to make it interactive. All without ever leaving Blade.
https://splade.dev
MIT License
1.47k stars 112 forks source link

Add usage support for power joins v3 #549

Closed luisdalmolin closed 8 months ago

luisdalmolin commented 9 months ago

First, I want to say it was a nice surprise to see the support for sorting the table component using Power Joins!

This PR is coming after this issue that was opened in the power joins repo directly. After a bit of digging, I saw that the package is using and checking the methods from v2, while we have some different ways of handling this on v3.

I believe we can make v2 or v3 work, depending only on what the user has installed. I pushed this PR with an attempt to solve this, but I wasn't able to actually test this yet. Do you have an easy way to verify if this is working? Otherwise, I'll try to create a demo project to make sure this is working.

pascalbaljet commented 8 months ago

Thanks for this! As of v1.4.17, only v3 is supported.