search

protontypes / LibreSelery

Continuous distribution of funding to your project contributors and dependencies. Integrated into GitHub Actions
GNU Affero General Public License v3.0
123 stars 18 forks source link

More defaults for cli args #64

Open cornerman opened 4 years ago

cornerman commented 4 years ago

Config should be default: directory/.selery.yml

What is a good default for results?

Can we use a file instead of env args for the tokens? Is it even better than enviroment variables?

Directory is needed or just github-repo?

kikass13 commented 4 years ago

@cornerman you guys already have a .openselery in your $HOME so using that for a results/run-<date>/... File tree would be fine I guess, else $PWD/results/... is always an option as well.

Having defaults for the configuration is not fine however, because they should to be explicitly displayed (transparent) for CI/personal use. But most times the configuration comes with a valid project (either local or github) containing a selery.yaml so your point gets valid again. I doubt that having a specially named file is a"good" solution but ita not that bad either.

The directory argument could also be called "target" and could potentially contain a github URL. We would have to clone it locally before doing stuff with it.