Closed nmstreethran closed 3 years ago
Hey @nmstreethran,
that's a good suggestion. It is easily implemented and should help to remove dead projects or redirected URLs. We should definitely test this. It would also help to read the list in a scripted way like we are planning to do: https://github.com/protontypes/open-sustainable-technology/issues/70
Things that could be relevant:
If you like to you are very welcome to create a pull request ( and test also our new Continuous Reforestation implementation :deciduous_tree:. I can also do it so that we have an implementation to discuss.
Thanks @Ly0n.
Regarding the GitHub server blocking the large number of requests, and error code 429 (Too Many Requests), awesome_bot has a --request-delay
option to delay each request. Setting it to a reasonable value (maybe 0.5 seconds?) will probably fix this, but it has to be tested. The action will take longer to complete, though.
I'll think about point 2 and other error codes and let you know if I come up with something. I'll check out the issue you referenced and the Continuous Reforestation repository as well in the coming week.
Sorry for the delay! I tried testing the links in README.md last night using awesome_bot locally. I found a few redirecting links, which you can see below. I've included the full log as an attachment.
Notes and observations:
Here's an example GitHub Action file which uses awesome_bot. I've set a monthly schedule and am using the Ruby gem method. Let me know what you think and if you would prefer using a different implementation.
Hi @nmstreethran , Thanks for your work! This is really good feedback. I will look into this and probably implement your suggested workflow soon. If you are interested in doing more with us, feel free to join any of our online meetings.
Thank you for the feedback, @tjarkdoering! I'm happy to contribute further and will join the meetings when possible.
That's really amazing and very important for our future work since we are planning to read metadata via the GitHub API to create a database out of it. That's why is is very important that the list always keep clean and readable in a machineable way. @nmstreethran You are very welcome to join our next session. Check out the slides the from the LF Energy conference yesterday to get some idea what we are gone do with the list in the future (slide 10): https://github.com/protontypes/organization-documents/blob/master/slides/protontypes_measuring_the_open_and_sustainable_technology_world.pdf
@nmstreethran. I checked your GitHub Action script and the URL issues you found. Again, great work. I would like to implement it today but do not want to steal your PR. For me, it is no problem to implement it but it is at the end your performance. What are your thoughts on it?
Hi @Ly0n, I do not mind either way. I can create a PR tomorrow, but if you wish to implement it today itself, then please go ahead.
By the way, are your meetings every Thursday at 18:30 CET? Just a heads up, the next meeting's date is incorrect in the organization-documents repository.
@nmstreethran . We use the organization-documents README just for logging. Normally we use we Gitter chat to announce the next meeting: https://gitter.im/protontypes/community
Most of the time we meet at least once per week at Thursday 18:30 CET. If you would like to join and this time is bad for your we could also switch it.
Sorry @tjarkdoering, I just noticed that you have made a commit regarding this issue!
Just one minute ago :smile: But it was only for the redirect links.
I will try to fix the conflicts :)
Thank you!
I think it has been fixed now. Let me know if there's anything else I can do!
Hi,
I think it would be a good idea to periodically check all the links in this repository and fix the ones that are redirecting.
For example, I noticed that the link to PowerGenome (https://github.com/gschivley/PowerGenome) redirects to https://github.com/PowerGenome/PowerGenome. If, in the future, a new repository or fork is created that points to the old URL, the link will no longer be correct.
To prevent this from happening, you could set up a scheduled GitHub Action with a link validator (such as awesome_bot) to check links every month or so. In addition to redirecting links, this will allow you to identify links that no longer exist, or name changes to projects.
Thanks and I apologise if you have already discussed this. I didn't find anything related in the issues so I thought I'll post my ideas here!