search

prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 640 forks source link

Scriptaculous Effect.Highlight no longer works with Prototype 1.7.1 #179

Closed jwestbrook closed 9 years ago

jwestbrook commented 10 years ago

previous lighthouse ticket #1379 by Fjan

I just noticed that upgrading Prototype from 1.7.0 to 1.7.1 breaks the often used Scriptaculous Highlight effect on all browsers I've tried. All other Scriptaculous Effects still work fine. No errors appear.

(I'm not sure if this should be reported here or on Scriptaculous, I'll report it there too, but the Prototype version number suggests it should be backwards compatible)

jwestbrook commented 10 years ago

Fjan September 6th, 2012 @ 03:12 PM

I traced this to the Enumerable#inject no longer working on a RangeObject in 1.7.1

$R(0,2).inject('#',function(m,v,i){return m+'|'+v+'-'+i; })

On Prototype 1.7.0 this yields: "#|0-0|1-1|2-2" On Prototype 1.7.1 this yields: "#|0-undefined|1-undefined|2-undefined"

chimit commented 9 years ago

Confirm.

savetheclocktower commented 9 years ago

This got fixed in #59.

savetheclocktower commented 9 years ago

(In other words, it works with 1.7.2.)