search

prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 640 forks source link

String#toQueryParams() should be opposite to Object.toQueryString() #180

Closed jwestbrook closed 9 years ago

jwestbrook commented 10 years ago

previous lighthouse ticket #1402 by Victor

In previous versions of Prototype String#toQueryParams() was exact opposite to Object.toQueryString(), i.e.

Object.toQueryString({"some name": "some value"}).toQueryParams()["some name"] === "some value";

It returned copy of source object. This symmetry is broken now: toQueryString() replaces spaces with + accordingly to HTML spec, but toQueryParams() does not restore them back:

Object.toQueryString({"some name": "some value"}).toQueryParams()["some name"] === "some+value";
jwestbrook commented 10 years ago

Riprock November 8th, 2012 @ 02:07 PM

I've just noticed this too. Caused a big problem with history insertion. Using 1.6.1 again now.

savetheclocktower commented 9 years ago

This got fixed in f2a1136992a7ade837ce6c3bf43eec4381793a7a.