search

prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 639 forks source link

prototype 1.7.1 set undefined attribute when style attribute is defined #218

Closed jwestbrook closed 9 years ago

jwestbrook commented 10 years ago

previous lighthouse ticket #1369 by loduis (at hotmail)

var element = new Element('span', {id: 'test', 'style': 'display:block'});
element.update('fixed me');
document.body.insert(element);
// prototype 1.7.1 set undefined attribute when style attribute is defined
// <span id="test" style="display: block; " undefined="display:block">fixed me</span>

View line 2786 in the framework

jwestbrook commented 10 years ago

Victor August 23rd, 2012 @ 06:24 PM

That bug was already in Prototype 1.7: http://jsfiddle.net/gcJaf/

jwestbrook commented 10 years ago

Victor August 23rd, 2012 @ 06:44 PM

The same behavior should be for checked attribute (for all attributes from ATTRIBUTE_TRANSLATIONS.write.values)

jwestbrook commented 10 years ago

Potentially already fixed by https://github.com/sstephenson/prototype/pull/80 ?

savetheclocktower commented 9 years ago

I'm going to assume so.