search

prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 639 forks source link

viewportOffset - introduced redundant code in 1.7.0.0 #232

Closed jwestbrook closed 9 years ago

jwestbrook commented 10 years ago

previous lighthouse ticket #1191 by Terry Johnson

The element extension line here is new since 1.7_rc3 and does not appear to wrap the correct variable:

  function viewportOffset(forElement) {
    element = $(element);
    var valueT = 0, valueL = 0, docBody = document.body;

    var element = forElement;

Suggested fix:

  function viewportOffset(forElement) {
    var valueT = 0, valueL = 0, docBody = document.body;
    var element = $(forElement);
jwestbrook commented 10 years ago

ronin-93814 (at lighthouseapp) March 13th, 2012 @ 02:33 PM

This looks like a duplicate of https://prototype.lighthouseapp.com/projects/8886/tickets/1176

savetheclocktower commented 9 years ago

This got fixed in #87.