prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 639 forks source link

can't enable/disable <button>'s #267

Closed jwestbrook closed 9 years ago

jwestbrook commented 9 years ago

previous lighthouse ticket #644 by sebastian


we can enable/disable form inputs with those functions but we cannot do that for tags currenty prototype only disable buttons if they are 's can only be disabled by setting but.disabled=true fixing this will make the API both, consistent and intuitive

jwestbrook commented 9 years ago

sebastian April 4th, 2009 @ 06:08 PM

some text was not displayed by lighthouse. I'll use brakets instead: we can enable/disable form inputs with those functions but we cannot do that for [button] tags. Currently prototype only disable buttons if they are [input type="submit]. [button]'s can only be disabled by setting button.disabled=true Fixing this will make the API both, consistent and intuitive

jwestbrook commented 9 years ago

Tobie Langel April 5th, 2009 @ 12:49 PM

Thanks for your suggestion. Due to the large number of suggestions we receive, we can only accept enhancement requests with tested patches in the form of a diff file or (preferably) a GitHub pull request. For help with creating a tested patch, see our contribute page. Please feel free to reopen this ticket once you have either of these ready. If you feel like discussing your enhancement proposal before working on a patch please join the conversation on the core mailing list. Thanks for taking the time to contribute!

jwestbrook commented 9 years ago

Victor March 6th, 2012 @ 10:44 AM

Ticket can be closed - button is extended with Form.Element.Methods (enable, disable, etc.)