prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 639 forks source link

Added new method for Object class, Object #isObject #289

Open rajuGT opened 9 years ago

rajuGT commented 9 years ago

Short explanation why I added this API.

I wrote a function which can process the request with variable arguments case A : arg0 -> property, arg1 -> value or case B : arg0 -> {properties : values}

So for the case (B), I need to make sure the param is only of type Object else the results will be odd. Because in javascript for in loop can loop over string by creating properties 0, 1, 2... for each character the string contains and also over String class properties.

Also most of the utility functions we write takes options/params parameter, which is an object (mostly containing flags) to add additional functionality for any utility. So looping over the options/params will be error free, if we make sure the param is Object type. This will also eliminates null check for options because if the parameter is null/undefined Object.isObject(null) returns false.

savetheclocktower commented 9 years ago

Hmm. Maybe.

Leaving this open for now so I can revisit it in a future version; next release will be a bugfix release.

savetheclocktower commented 8 years ago

Closing because we're removing support for IE 8 and below.

savetheclocktower commented 8 years ago

Whoops, wrong PR. Sorry.