search

prototypejs / prototype

Prototype JavaScript framework
http://prototypejs.org/
Other
3.54k stars 639 forks source link

Remove old browser support. #307

Closed jdalton closed 8 years ago

jdalton commented 8 years ago

This PR removes old IE support (IE < 9), old Opera support, and old Safari support. This also removes support for the attachEvent fork so IE 9 using the older branch is gone.

My editor removed trailing whitespace which is a bit noisy but also a nice thing. I can try to parse it out if necessary.

I left the Function#bind shim in because of PhantomJS 1.9 (isn't a problem in 2.0). I've test this in IE9 unit tests + functional tests and PhantomJS.

Closes #306.

jdalton commented 8 years ago

Tested in IE 9, IE 11, Edge, Firefox (41 and 42), Safari (8 and 9), Chrome (45 and 46), and PhantomJS.

savetheclocktower commented 8 years ago

What will this do to, e.g., IE 9 in IE 7 mode?

jdalton commented 8 years ago

What will this do to, e.g., IE 9 in IE 7 mode?

Support has been removed for IE < 9 and that means older compat modes. Folks using IE9 can use the Edge X-UA-Compatible mode to ensure IE isn't running in an older one.

jdalton commented 8 years ago

Ping

savetheclocktower commented 8 years ago

I'll probably get to this sometime over the holidays when I'm bored. Don't worry; I won't forget about it.

jdalton commented 8 years ago

Rock! I've got 2 weeks of downtime over the holidays too :gift:

savetheclocktower commented 8 years ago

OK, I'm cool with landing this. One thing I'll probably do is put back Element.extend but assign it to Prototype.K; that function is technically part of the public API and I don't want to surprise anyone who's relying on it.

savetheclocktower commented 8 years ago

Whoops, you already did that. I am good at reading.

jdalton commented 8 years ago

:fireworks: !