protyposis / Aurio

Audio Fingerprinting & Retrieval for .NET
GNU Affero General Public License v3.0
128 stars 28 forks source link

Updating your code to the newest Chromaprint version? #1

Closed PeterCodar closed 7 years ago

PeterCodar commented 7 years ago

The original author of Chromaprint has updates his version to 1.4 recently: https://github.com/acoustid/chromaprint/releases/tag/v1.4.2

Could you please have a look and update your C# code with the new changes?

protyposis commented 7 years ago

Looking at the 1.4.x changelogs, it seems that the changes have either already been implemented in Aurio or are not relevant.

Can you confirm my code is not compatible with Chromaprint any more?

PeterCodar commented 7 years ago

I can't confirm that your code is not compatible anymore. It just lacks of some nice features like the JSON output or the ability to fingerprint (partial) streams.

protyposis commented 7 years ago

Aurio has been designed for stream processing and fingerprinting of streams from the beginning, so this is definitely implemented.

There's no JSON output because Aurio doesn't focus on output formats. It provides raw fingerprints and it's up to the user to handle them (e.g. save as JSON). If you look at the Generate fingerprints example, the SubFingerprintsGenerated listener receives the raw fingerprints and you can easily save them to JSON from there.

PeterCodar commented 7 years ago

I see, thank you for your explanation.

I found your project because it is listed as "C# (reimplementation)" of chromaprint on https://github.com/acoustid/chromaprint#related-projects

protyposis commented 7 years ago

Ok, thanks for letting me know!