Closed sphh closed 4 years ago
Well, this became a bit of a mess keeping the 5 PRs separate, because they started to have an impact on each other. On the other hand I was not sure, if you like all of them, so I kept them separate for you to choose.
Do you think, it's possible to revert the PR #46, which is already merged? That should help applying this PR cleanly.
I will also update this PR with the notes from https://github.com/protz/LatexIt/pull/50#discussion_r450332110 and https://github.com/protz/LatexIt/pull/51#discussion_r450333143 (Please can you comment on https://github.com/protz/LatexIt/pull/51#discussion_r450382284. Thanks!)
What is your opinion about https://github.com/protz/LatexIt/pull/46#issuecomment-608092034? If I am at it, I could change it.
I've forced-push to forget the merge of the previous PR, so now you should be able to combine everything into this PR, then I'll merge this one, followed by #54
Thanks for reverting #46! That helped really a lot!!
Hi Jonathan @protz ,
What started as a tiny exercise to sort out the insertion of complex LaTeX turned out to become a bit more elaborated. My first idea was to keep them all separated to help in cherry picking the PRs you like, but I am not sure if I managed to keep them really separate. I might have missed one or two diffs (but I do not hope so). So here comes the all-in-one PR including #46 #47 #50 #51 #52. Feel free to use this one or any of the others. And thanks for starting this wonderful add-on!
Here is an overview of all the changes:
__REPLACEME__
with__REPLACE_ME__
, which IMHO is easier to the eye.