protz / ocaml-installer

The official windows installer (built using NSIS) for OCaml
http://protz.github.com/ocaml-installer/
GNU General Public License v3.0
66 stars 11 forks source link

wipes out ENV variables #1

Closed egbutter closed 12 years ago

egbutter commented 12 years ago

Hi Jonathan:

Thanks for putting together this great executable. FYI, the installer wiped out my ENV variables (latest "stable" mingw installer on Windows 7). I am not comfortable enough with this code to figure out why myself right now ... just thought I should let you know.

Cheers, and thanks again!

protz commented 12 years ago

all ENV variables or just the ocaml ones?

egbutter commented 12 years ago

The Ocaml and TCL variables replaced all my _other ENV variables; so the final state of the system-wide ENV variables was (C:\Tcl\bin;C:\OCaml\bin;).

On Sun, Nov 6, 2011 at 5:45 PM, Jonathan Protzenko < reply@reply.github.com>wrote:

all ENV variables or just the ocaml ones?


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648310

protz commented 12 years ago

On 11/6/2011 11:52 PM, egbutter wrote:

The Ocaml and TCL variables replaced all my _other ENV variables; so the final state of the system-wide ENV variables was (C:\Tcl\bin;C:\OCaml\bin;). I do not understand what you are talking about. Are you talking about the PATH environment variable? An environment variable has a name and a value. Please tell me what is the name of the environment variable that was damaged, what is its value now, what used to be its value.

Thanks,

jonathan

On Sun, Nov 6, 2011 at 5:45 PM, Jonathan Protzenko< reply@reply.github.com>wrote:

all ENV variables or just the ocaml ones?


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648310


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648351

egbutter commented 12 years ago

Correct, the PATH env variable. Before: C:\prover9\bin;C:\pscp;C:\puTTY;C:\Python27;C:\Python27\Scripts;C:\R\R-2.14.0\bin;C:\Vim\vim73;C:\boost\boost_1_47_0; ... and many more. After: C:\Tcl\bin;C:\OCaml\bin; Sorry I was not too clear. Cheers,

Eric

On Mon, Nov 7, 2011 at 3:55 AM, Jonathan Protzenko < reply@reply.github.com>wrote:

On 11/6/2011 11:52 PM, egbutter wrote:

The Ocaml and TCL variables replaced all my _other ENV variables; so the final state of the system-wide ENV variables was (C:\Tcl\bin;C:\OCaml\bin;). I do not understand what you are talking about. Are you talking about the PATH environment variable? An environment variable has a name and a value. Please tell me what is the name of the environment variable that was damaged, what is its value now, what used to be its value.

Thanks,

jonathan

On Sun, Nov 6, 2011 at 5:45 PM, Jonathan Protzenko< reply@reply.github.com>wrote:

all ENV variables or just the ocaml ones?


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648310


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648351


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2651218

protz commented 12 years ago

Looks like you just hit the 1024 character string length limitation in the installer I'm using...

On Mon 07 Nov 2011 01:45:10 PM CET, egbutter wrote:

Correct, the PATH env variable. Before: C:\prover9\bin;C:\pscp;C:\puTTY;C:\Python27;C:\Python27\Scripts;C:\R\R-2.14.0\bin;C:\Vim\vim73;C:\boost\boost_1_47_0; ... and many more. After: C:\Tcl\bin;C:\OCaml\bin; Sorry I was not too clear. Cheers,

Eric

On Mon, Nov 7, 2011 at 3:55 AM, Jonathan Protzenko< reply@reply.github.com>wrote:

On 11/6/2011 11:52 PM, egbutter wrote:

The Ocaml and TCL variables replaced all my _other ENV variables; so the final state of the system-wide ENV variables was (C:\Tcl\bin;C:\OCaml\bin;). I do not understand what you are talking about. Are you talking about the PATH environment variable? An environment variable has a name and a value. Please tell me what is the name of the environment variable that was damaged, what is its value now, what used to be its value.

Thanks,

jonathan

On Sun, Nov 6, 2011 at 5:45 PM, Jonathan Protzenko< reply@reply.github.com>wrote:

all ENV variables or just the ocaml ones?


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648310


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648351


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2651218


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2652973

protz commented 12 years ago

Note to self: use the large string build from http://nsis.sourceforge.net/Special_Builds next time

On Mon 07 Nov 2011 01:48:00 PM CET, Jonathan Protzenko wrote:

Looks like you just hit the 1024 character string length limitation in the installer I'm using...

On Mon 07 Nov 2011 01:45:10 PM CET, egbutter wrote:

Correct, the PATH env variable. Before: C:\prover9\bin;C:\pscp;C:\puTTY;C:\Python27;C:\Python27\Scripts;C:\R\R-2.14.0\bin;C:\Vim\vim73;C:\boost\boost_1_47_0;

... and many more. After: C:\Tcl\bin;C:\OCaml\bin; Sorry I was not too clear. Cheers,

Eric

On Mon, Nov 7, 2011 at 3:55 AM, Jonathan Protzenko< reply@reply.github.com>wrote:

On 11/6/2011 11:52 PM, egbutter wrote:

The Ocaml and TCL variables replaced all my _other ENV variables; so the final state of the system-wide ENV variables was (C:\Tcl\bin;C:\OCaml\bin;). I do not understand what you are talking about. Are you talking about the PATH environment variable? An environment variable has a name and a value. Please tell me what is the name of the environment variable that was damaged, what is its value now, what used to be its value.

Thanks,

jonathan

On Sun, Nov 6, 2011 at 5:45 PM, Jonathan Protzenko< reply@reply.github.com>wrote:

all ENV variables or just the ocaml ones?


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648310


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2648351


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2651218


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-2652973

miau commented 12 years ago

It would be helpful if you could create a new installer. With this problem, I hesitate to recommend OCaml to Windows users.

egbutter commented 12 years ago

I hesitate to recommend Windows =) we make have with what we are given!

protz commented 12 years ago

I'm happy to announce that the new installer at http://yquem.inria.fr/~protzenk/caml-installer/ocaml-4.01.0+dev0-i686-mingw64.exe is able to cope with larger PATHs and won't blast the PATH in case it really is super-long.

djcsdy commented 12 years ago

Please can you put a warning in front of the link to the old version of the installer, which still has this problem.

I just ran it and I now have several hours work ahead of me fixing every other command-line tool on my system. I know it’s “unsupported” but I wasn’t expecting it to do serious damage.

protz commented 12 years ago

Alright, I guess it's fair I put up a bigger warning. The page has been updated.

On Mon 16 Jul 2012 06:13:43 PM CEST, Daniel Cassidy wrote:

Please can you put a warning in front of the link to the old version of the installer, which still has this problem.

I just ran it and I now have several hours work ahead of me fixing every other command-line tool on my system. I know it’s “unsupported” but I wasn’t expecting it to do serious damage.


Reply to this email directly or view it on GitHub: https://github.com/protz/ocaml-installer/issues/1#issuecomment-7010724

djcsdy commented 12 years ago

Thanks! I hate to think of someone else suffering the same fate! :)