search

proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

Service center iframes #1905

Open lukefretwell opened 2 years ago

lukefretwell commented 2 years ago

All iframes (forms within "Website feedback" and "Report an issue") are missing a name. Recommend adding descriptive name to each iframe with a title attribute.

aschmoe commented 2 years ago

LOE: 30 minutes

kevindherman commented 2 years ago

@aschmoe @lukefretwell right now it displays the form title when it's a PC form so nothing shows in the case of a iFrame. Would it be more efficient that the display is the "issue name" rather than the form? That way it's the same for forms, iframes and text.

kevindherman commented 2 years ago

@jlyon @aschmoe @lukefretwell is this item actually done and should be marked as closed?

jlyon commented 2 years ago

Not seeing a title attribute on the iframe tag on https://publicworks.marincounty.org/#/city/report/embed/parking-related:

Screen Shot 2021-12-02 at 9 36 54 PM
kevindherman commented 2 years ago

@jlyon is this something that would come from the customer side or us?

aschmoe commented 2 years ago

@kevindherman @jlyon unclear if this was completed, not seeing anything in commit history to support the hotfix push we see referenced above