search

proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

Events sequence of headings is not in sequential order from H1-H6 #2497

Open lukefretwell opened 3 months ago

lukefretwell commented 3 months ago

Source

https://airtable.com/appRFUc45sF4yWFut/tbl51inE74gEWlB0x/viwG9G4vAjsjQEh4g/recO93Nbf5CaQrRdQ?blocks=hide

Describe the bug

A clear and concise description of what the bug is.

The sequence of headings is not in sequential order from H1-H6. Headings in a sequential order better support creating an understanding via audio of the important elements of the page. Notice that H4 is skipped in the sequence.

Screenshots

If applicable, add screenshots to help explain your problem.

Heading Sequence

curtismchale commented 3 months ago

@lukefretwell this is easy from a code perspective. If we want to make the time an h4 I can do that. If we want to revamp the heading structure...thats' a longer discussion but the implementation is still easy from a code perspective.

lukefretwell commented 3 months ago

@curtismchale making it an h4 is the easiest and probably what we should do for now. Don't love that it's a heading.

curtismchale commented 3 months ago

@lukefretwell if we don't love that it's a heading then let's make it something else. We could use the <time> element as shown here.

If I'm changing it changing it to something else is just as easy.

lukefretwell commented 3 months ago

@curtismchale anything we can do to add semantic HTML is always a win. For the HTML, it will still need some style (p or ul) for the date and time and seems like ul would be more accessible.