proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

<li> elements must be contained in an <ol> or <ul> element. #2500

Closed lukefretwell closed 2 months ago

lukefretwell commented 3 months ago

Builds

Source

https://airtable.com/appRFUc45sF4yWFut/tbl51inE74gEWlB0x/viwG9G4vAjsjQEh4g/rec4I1tKOMEBcWAvU?blocks=hide

Describe the bug

A clear and concise description of what the bug is.

<li> elements must be contained in an <ol> or <ul> element. List item does not have a <ul>, <ol> parent element without a role, or a role="list". Currently the use of "role="navigation" on the UL's is obscuring their semantic role. `

Recommendations

This occurs in the following locations. Update the following sections:

  1. The three skip links. Remove the "Role=Navigation" from the <ul>. This will allow a user to hear it is a list and that there are three items. Add a role="navigation" to the preceding div or add the <nav> element around the whole list.
  2. The menu items in the navigation menu Same solution as noted above.
  3. The Search link Similar issue occuring with role="toolbar"

Screenshots

If applicable, add screenshots to help explain your problem. list 2 lists 1

curtismchale commented 2 months ago

Deployed Build: https://github.com/proudcity/proud-recipes/releases/tag/2024.05.02.1420x Composer: https://github.com/proudcity/wp-proudcity/releases/tag/2024.05.02.1420