proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

Remove nav bottom CSS #2501

Open lukefretwell opened 3 months ago

lukefretwell commented 3 months ago

Source

https://airtable.com/appRFUc45sF4yWFut/tbl51inE74gEWlB0x/viwG9G4vAjsjQEh4g/reclZ8BDghwMCuKaZ?blocks=hide

Describe the bug

A clear and concise description of what the bug is.

In the mobile view, focus moves from the Skip Links section at the top left of the page to the bottom of the page through the navigation links and then back up to the logo. Focus typically moves from top to bottom and left to right in a logical focus order. Ideally, we would recommend having the mobile nav be at the top of the page in logical order.

One example of an issue this design presents is for a keyboard only user it is difficult to tell once one is navigating through the page whether one should go to the top of the page or the bottom of the page to reach the menu. The answer is the top of the page, but visually it can look to a user that it is at the bottom of the page. However, if one navigates to the bottom, the link is not there. One needs to continue navigating to reach it again at the top.

Another example is for a low vision user who has the screen magnified. It may be hard to see where focus moved as it "jumps" past where one might expect in the logical focus order and they may miss the updated focus visible.

Recommendations

We would recommend not putting your main navigation at the bottom of the page visually. https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html

Screenshots

If applicable, add screenshots to help explain your problem.

https://github.com/proudcity/wp-proudcity/assets/1569463/bd9d1751-817c-48a0-bbdc-968d1b5cbdf8