search

proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

Change name of filter button to "Apply Filters" #2524

Closed lukefretwell closed 3 months ago

lukefretwell commented 3 months ago

Builds

Source

https://airtable.com/appRFUc45sF4yWFut/tbl51inE74gEWlB0x/viwG9G4vAjsjQEh4g/recuzE962cNqhepj3?blocks=hide

Describe the bug

A clear and concise description of what the bug is.

When the screen reader user heard "filter" he assumed it was a button to open a modal with more filters. He bypassed it and expected that the filter he had checked would have been applied already.

Recommendation

Recommend changing the name of the button to "Apply Filters" to make it clear that it should be selected in order for the selection to be aplied.

Screenshots

If applicable, add screenshots to help explain your problem.

filter

curtismchale commented 3 months ago

@kevindherman @lukefretwell this is deployed to beta. You can see the new button text here: https://beta.proudcity.com/events/

kevindherman commented 3 months ago

@curtismchale @lukefretwell looks good to me.

curtismchale commented 3 months ago

Deployed Composer: https://github.com/proudcity/wp-proudcity/releases/tag/2024.04.04.0737 Build: https://github.com/proudcity/proud-recipes/releases/tag/2024.04.04.0737