proudcity / wp-proudcity

The ProudCity WordPress platform
https://proudcity.com
Other
21 stars 9 forks source link

Remove link color styling from skip nav links #2572

Open lukefretwell opened 1 week ago

lukefretwell commented 1 week ago

Source

Describe the bug

A clear and concise description of what the bug is.

It seems like WAVE is throwing a contrast error for the skip nav link color for this site (not for others). I don't see a contrast issue using the WAVE contrast checker, so not sure why it would be a problem here.

Suggestion would be to exclude color styling from skip nav.

<ul id="skiplinks" aria-label="Skip links">
    <li><a href="#content-main" class="sr-only">Skip to content</a></li>
    <li><a href="#navbar-external" class="sr-only">Skip to navigation</a></li>
    <li><a href="/sitemap" class="sr-only">Site map</a></li>
    </ul>

To reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Add any other context about the problem here.

QA

Notes:

Links:

*

kevindherman commented 1 week ago

@lukefretwell here's the customer's screenshot from the ticket: image001 (25)