'News Posts list' widget all sites category filter broken

lukefretwell commented 3 months ago

This widget should pull the selected category of the main site that the widget is located on, then additionally it should pull the remote category from other specified sites. This is specified with cat_id on the external site. Currently it pulls the selected category of the current site, and it pulls any additional cat_id specified in the advanced settings from both the external site and the current site.

See developer docs

Source

The 'News Posts list' widget isn't working as I'd expect it to.

Example: https://proudcity.com/recovers/

Describe the bug

A clear and concise description of what the bug is.

When selecting 'All Sites' in the news posts list widget and then entering 'External category ids' category ID numbers, it also displays posts for the current site.

On the recovers page, you can see it's showing ID 213 from proudcity.com which is the 'GovTech 100' category.

To reproduce

Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Add any other context about the problem here.

QA

Notes:

Links:

*

curtismchale commented 2 months ago

@lukefretwell we can do this but upon investigation it's part of the Elastic integration that @aschmoe is working on. To do this work currently I'd drop the elastic integration and let users specify which site they want to pull data from, return the category options and then let them choose the categories. This would take Elastic out of the equation entirely.

Questions

I have no idea which users are currently using this feature so it would be hard to test for edge cases without knowing exactly what they're doing. I can probably remove admin settings for this but leave the frontend working so all new sites would use the new interface without killing existing functionality.

I anticipate this is a task that will take the rest of this week to get right. Is it worth doing or should we move it to the future?

curtismchale commented 2 months ago

This has been moved to the backlog based on the meeting 2024.09.05

proudcity / wp-proudcity