proudmonkey / AutoWrapper

A simple, yet customizable global exception handler and Http response wrapper for ASP.NET Core APIs.
MIT License
677 stars 82 forks source link

Ready for production #1

Closed sajidali2444 closed 5 years ago

sajidali2444 commented 5 years ago

Hi, Thank you for such great Wrapper really like it. I am currently using VMD.RESTApiResponseWrapper.Core package is different than VMD.RESTApiResponseWrapper.Core? and one thing more is it ready for production? When are you planning final release?

proudmonkey commented 5 years ago

@sajidali2444,

Thank your interest in using this wrapper. I'm glad you find it useful. :)

is different than VMD.RESTApiResponseWrapper.Core?

The usage is different due namespace renaming, but it shouldn't be that complex. Please read the readme section on how to use it in your ASP.NET Core project.

The project is still in .NET Core 3 - RC version. It will be officially released today (Sept 23rd). Once that's out, I will update the package reference for official release. Hopefully today. :)

According to MS:

"NET Core 3.0 Preview RC1 is supported by Microsoft and can be used in production. We strongly recommend that you test your app running on Preview RC1 before deploying into production"

For details, see: https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0-release-candidate-1/

sajidali2444 commented 5 years ago

Thanks for the update. I am already using your old package in .NET Core 2.2 and much happy. But one problem I am facing when API throw error you package not wrapping error properly. may I send you a sample ?

On Mon, Sep 23, 2019 at 10:15 PM Vincent Maverick Durano < notifications@github.com> wrote:

@sajidali2444 https://github.com/sajidali2444,

Thank your interest in using this wrapper.

The project is still in .NET Core 3 - RC version. It will be officially released today (Sept 23rd). Once that's out, I will update the package reference for official release. Hopefully today. :)

According to MS:

"NET Core 3.0 Preview RC1 is supported by Microsoft and can be used in production. We strongly recommend that you test your app running on Preview RC1 before deploying into production"

For details, see: https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0-release-candidate-1/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/proudmonkey/AutoWrapper/issues/1?email_source=notifications&email_token=AAHKQ3DVNZ5B6VBFT5OCAKDQLD2SZA5CNFSM4IZG2IXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LS7SA#issuecomment-534196168, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHKQ3FT3Y35HUIC7DQVUEDQLD2SZANCNFSM4IZG2IXA .

-- Best Regard: Sajid Ali Software Engineer (+92) 333 6528504 / 321 786 5510

proudmonkey commented 5 years ago

The old package had a few glitches on the code. Please try to use the AutoWrapper instead. I would say that supports backward compatibility. Try it and let me know.

proudmonkey commented 5 years ago

@sajidali2444 ,

AutoWrapper is now officially released: http://vmsdurano.com/autowrapper-is-officially-released/

sajidali2444 commented 5 years ago

I am hoping and pretty sure this package will become standard and need for API.

On Tue, Sep 24, 2019 at 6:49 AM Vincent Maverick Durano < notifications@github.com> wrote:

@sajidali2444 https://github.com/sajidali2444 ,

AutoWrapper is now officially released: http://vmsdurano.com/autowrapper-is-officially-released/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/proudmonkey/AutoWrapper/issues/1?email_source=notifications&email_token=AAHKQ3HUQTTZZEUQ6O3JETDQLFWY5A5CNFSM4IZG2IXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MZGEY#issuecomment-534352659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHKQ3G5VPSE7MR4IREGE6LQLFWY5ANCNFSM4IZG2IXA .

-- Best Regard: Sajid Ali Software Engineer (+92) 333 6528504 / 321 786 5510

proudmonkey commented 5 years ago

Thank you, @sajidali2444 :)

Hopefully others will find this useful too. Just so you know, we are using this to standardize our API response for all of our API projects.

sajidali2444 commented 4 years ago

Hi Friend Thank you for .net core support and its awesome package I am using it. one problem noted maybe my direction wrong. Swagger UI not working with AutoWrapper package it's saying this message. AutoWrapper is meant to be used for ASP.NET Core API project templates only. If you are combining API Controllers within your front-end projects like Angular, MVC, React, Blazor and other SPA frameworks that supports .NET Core, then set the AutoWrapperOptions IsApiOnly property to false. could you please help me how I can use swagger API explore as I am using .net core 3 API project

On Wed, Sep 25, 2019 at 12:35 AM Vincent Maverick Durano < notifications@github.com> wrote:

Thank you, @sajidali2444 https://github.com/sajidali2444 :)

Hopefully others will find this useful too. Just so you know, we are using this to standardize our API response for all of our API projects.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/proudmonkey/AutoWrapper/issues/1?email_source=notifications&email_token=AAHKQ3AQKQAXK5IGIZYWR4LQLJTZXA5CNFSM4IZG2IXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PRXMA#issuecomment-534715312, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHKQ3HAJZWNTJNFGJ6JUXLQLJTZXANCNFSM4IZG2IXA .

-- Best Regard: Sajid Ali Software Engineer (+92) 333 6528504 / 321 786 5510

proudmonkey commented 4 years ago

@sajidali2444 Swagger should work. Take a look at this API Template that uses both AutoWrapper and Swagger: https://github.com/proudmonkey/ApiBoilerPlate

Are you mixing your API with SPA frameworks?

sajidali2444 commented 4 years ago

No I am not mixing api with spa My React app is separate and API is separate. should I show you my configure method?

On Thu, Dec 12, 2019 at 8:04 PM Vincent Maverick Durano < notifications@github.com> wrote:

@sajidali2444 https://github.com/sajidali2444 Swagger should work. Take a look at this API Template that uses both AutoWrapper and Swagger: https://github.com/proudmonkey/ApiBoilerPlate

Are you mixing your API with SPA frameworks?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/proudmonkey/AutoWrapper/issues/1?email_source=notifications&email_token=AAHKQ3D77FEYN427RY263CTQYJHIDA5CNFSM4IZG2IXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGW6I4Y#issuecomment-565044339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHKQ3AJ3V3BYTY5NEY5F23QYJHIDANCNFSM4IZG2IXA .

-- Best Regard: Sajid Ali Software Engineer (+92) 333 6528504 / 321 786 5510

proudmonkey commented 4 years ago

Then that should work. Yes please show me your Configure method.