provable-things / ethereum-api

Provable API for Ethereum smart contracts
https://docs.provable.xyz/#ethereum
MIT License
800 stars 428 forks source link

Feat/connector v1.3 rebased WIP #94

Closed D-Nice closed 5 years ago

D-Nice commented 5 years ago

Just draft to verify correct rebasing. Apologies to @gskapka on the dual authorship, can circumvent it by having you redo my steps, and it should only be your authorship in that case, which is more correct.

D-Nice commented 5 years ago

recent org rename broke the ci, and had to resync it

gskapka commented 5 years ago

Apologies to @gskapka on the dual authorship

Don't be daft. Completely fine by me. Plus if you drill into it it points us out as the author & the committer separately. Plus I'm still the one who'll get git blamed :rofl: But yah, LGTM.

D-Nice commented 5 years ago

closing as rebase has been done on https://github.com/provable-things/ethereum-api/pull/88