Closed TheVeryDarkness closed 9 months ago
Since this is only used for getting a sysroot for running clang to generate the enum bindings, perhaps we can solve this in an even simpler way... Could we just copy a couple of files into an z3-sys/ext/wasm-sysroot
to give a minimal stdbool.h
, stdint.h
and stdio.h
?
Actually, I think I can submit a PR to upstream to remove in the include of stdiio.h
from here...
Would it be possible to rebase this against current
master
and eliminate a bunch of the commits so that I can see what a clean history might look like?
Oh, I'm sorry. Let me take a glance at git rebase
.
Since this is only used for getting a sysroot for running clang to generate the enum bindings, perhaps we can solve this in an even simpler way... Could we just copy a couple of files into an
z3-sys/ext/wasm-sysroot
to give a minimalstdbool.h
,stdint.h
andstdio.h
?Actually, I think I can submit a PR to upstream to remove in the include of
stdiio.h
from here...
Yep, I think those ways should be better.
I'm going to close this and will do the wasm-sysroot
changes this weekend. Thanks for bringing this up!
(Also, I got a change merged upstream already to remove the inclusion of stdio.h
)
I'm going to close this and will do the
wasm-sysroot
changes this weekend. Thanks for bringing this up!(Also, I got a change merged upstream already to remove the inclusion of
stdio.h
)
Sounds great :)
Homebrew only provides emscripten but not a full emsdk, so brew users may need an extra environment variable
EMSCRIPTEN_ROOT
.In the past versions, emscripten is considered only when the target is wasm32-unknown-emscripten, but it may be needed for other wasm targets. I add supports for other wasm32 targets. And missing emscripten won't cause a panic for non *-emscripten targets.
And we can test it on wasm32 targets if vcpkg-rs supports them later. Related PR has been merged but has not been published to crates.io.