provectus / kafka-ui

Open-Source Web UI for Apache Kafka Management
Apache License 2.0
8.97k stars 1.1k forks source link

useConfirm hook refactoring #3809

Open NeiruBugz opened 1 year ago

NeiruBugz commented 1 year ago

In #3662 was introduced additional parameter for useConfirm hook, that modifies ConfirmationModal elements

In this case we need to use multiple useConfirm modals because if we need to render multiple modals that differs with normal/danger states - this causes a bit more boilerplate when using hook

It is possible to build some kinda useDangerModal hook, but this will cause code dupes, mostly

github-actions[bot] commented 1 year ago

Hello there NeiruBugz! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀