search

provegard / ncdbg

A debugger for Nashorn that uses Chrome DevTools as frontend
BSD 3-Clause "New" or "Revised" License
31 stars 5 forks source link

Investigate how we use the silent flag #87

Closed provegard closed 6 years ago

provegard commented 6 years ago

E.g. from Runtime.callFunctionOn:

In silent mode exceptions thrown during evaluation are not reported and do not pause execution. Overrides setPauseOnException state.

What does "are not reported" mean? Because DevTools has code that checks exceptionDetails even if silent is true, so perhaps it means that we shouldn't raise an event for an exception?

provegard commented 6 years ago

From https://github.com/v8/v8/blob/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/inspector/v8-runtime-agent-impl.cc#L134

if (silent) scope.ignoreExceptionsAndMuteConsole();
provegard commented 6 years ago

https://github.com/v8/v8/blob/bf505e6065d2b66a367bb7d9a8f3e187838c7fd8/src/inspector/injected-script.cc#L676