provenance-io / explorer-service

The server side of the blockchain Explorer app. Allows for UI browsing of the blockchain.
Apache License 2.0
6 stars 3 forks source link

Fix get upgrade plan method #524

Closed nullpointer0x00 closed 3 months ago

nullpointer0x00 commented 3 months ago

Description

This PR addresses a bug in the Proto deserialization logic where the full type URL is not being used to determine the handling of upgrade proposals. The current implementation checks if typeUrl contains "SoftwareUpgradeProposal", which incorrectly matches both cosmos.upgrade.v1beta1.CancelSoftwareUpgradeProposal and cosmos.upgrade.v1beta1.SoftwareUpgradeProposal.

This issue was exposed during the v1.19.0-rc upgrade when a canceled upgrade proposal was incorrectly processed.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.