This PR addresses a bug in the Proto deserialization logic where the full type URL is not being used to determine the handling of upgrade proposals. The current implementation checks if typeUrl contains "SoftwareUpgradeProposal", which incorrectly matches both cosmos.upgrade.v1beta1.CancelSoftwareUpgradeProposal and cosmos.upgrade.v1beta1.SoftwareUpgradeProposal.
This issue was exposed during the v1.19.0-rc upgrade when a canceled upgrade proposal was incorrectly processed.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes
Description
This PR addresses a bug in the Proto deserialization logic where the full type URL is not being used to determine the handling of upgrade proposals. The current implementation checks if
typeUrl
contains"SoftwareUpgradeProposal"
, which incorrectly matches bothcosmos.upgrade.v1beta1.CancelSoftwareUpgradeProposal
andcosmos.upgrade.v1beta1.SoftwareUpgradeProposal
.This issue was exposed during the v1.19.0-rc upgrade when a canceled upgrade proposal was incorrectly processed.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes