Closed SpicyLemon closed 4 months ago
This update enhances the application's handling of scope NAVs by introducing new constants for mainnet and testnet configurations, improving test coverage, and incorporating robust error handling in the upgrade process. The changelog entries provide clarity on recent improvements, including the successful implementation of new functionalities, enhancing both the organization of constants and the overall upgrade mechanics.
Files | Change Summary |
---|---|
CHANGELOG.md | Added entry for recording scope NAVs related to pull request #2085; clarified improvements. |
app/scope_navs_updater.go | Introduced umberMainnetScopeNAVsFN ; organized constants for scope NAVs. |
app/scope_navs_updater_test.go | Added new test case to TestReadScopeNAVs to improve test coverage with specific expected values. |
app/upgrades.go | Added addScopeNAVs function call with error handling for the upgrade process. |
app/upgrades_test.go | Introduced log messages in TestUmber to document operations during test execution without altering logic. |
sequenceDiagram
participant App
participant UpgradeProcess
participant AddScopeNAVs
App->>UpgradeProcess: Initiate upgrade
UpgradeProcess->>AddScopeNAVs: Call addScopeNAVs()
AddScopeNAVs-->>UpgradeProcess: Return success or error
UpgradeProcess-->>App: Complete upgrade with status
🐰 In fields of green, we hop with glee,
New NAVs in hand, oh what a spree!
With tests that dance and flows so bright,
Upgrades abound in morning light!
So let us cheer with joyful prance,
For every change, we’ll take a chance! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
This PR adds a step to the umber upgrade that will set the NAV info for a bunch of scopes.
It's in "draft" until we get a final updated csv of the entries.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passesSummary by CodeRabbit
Improvements
Logging Updates