search

provenance-io / provenance

A distributed, proof of stake blockchain designed for the financial services industry.
https://provenance.io
Apache License 2.0
89 stars 39 forks source link

Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 #2120

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps github.com/cometbft/cometbft from 0.38.10 to 0.38.11.

Release notes

Sourced from github.com/cometbft/cometbft's releases.

v0.38.11

CHANGELOG

Changelog

Sourced from github.com/cometbft/cometbft's changelog.

v0.38.11

August 12, 2024

This release fixes a panic in consensus where CometBFT would previously panic if there's no extension signature in non-nil Precommit EVEN IF vote extensions themselves are disabled.

It also includes a few other bug fixes and performance improvements.

BUG FIXES

  • [types] Added missing JSON tags to DuplicateVoteEvidence and LightClientAttackEvidence types (#3528)
  • [types] Only check IFF vote is a non-nil Precommit if extensionsEnabled types (#3565)

IMPROVEMENTS

  • [indexer] Fixed ineffective select break statements; they now point to their enclosing for loop label to exit (#3544)
Commits
  • e1b4453 v0.38.11 (#3684)
  • 66a0447 build(deps): Bump docker/build-push-action from 6.5.0 to 6.6.1 (#3676)
  • cd3519d build(deps): Bump bufbuild/buf-setup-action from 1.35.1 to 1.36.0 (#3675)
  • c17d1f6 fix(types): Only require extension signature if extensions are enabled (#3565)
  • f85d897 feat(mempool): add error ErrRecheckFull (backport #3654) (#3656)
  • 9de925c fix(e2e): replace docker-compose w/ docker compose (backport #3614) (#3616)
  • e9bd8a9 build(deps): Bump docker/setup-buildx-action from 3.5.0 to 3.6.1 (#3610)
  • 61ca12e build(deps): Bump docker/setup-buildx-action from 3.4.0 to 3.5.0 (#3584)
  • cba216a build(deps): Bump docker/login-action from 3.2.0 to 3.3.0 (#3585)
  • aaf83e9 build(deps): Bump docker/build-push-action from 6.4.1 to 6.5.0 (#3586)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent changes involve updating the github.com/cometbft/cometbft dependency from version 0.38.10 to 0.38.11. This update is documented in the CHANGELOG.md and go.mod files, ensuring clarity about external dependencies and informing users of the improvements or fixes introduced. Additionally, the test suite for configuration commands has been enhanced to validate the version format dynamically, improving its reliability without altering any public entity declarations.

Changes

File(s) Change Summary
CHANGELOG.md, go.mod Updated github.com/cometbft/cometbft from v0.38.10 to v0.38.11, documenting the dependency version change.
cmd/provenanced/cmd/config_test.go Enhanced TestConfigCmdGet to validate CometBFT version format dynamically in configuration output.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant CometBFT

    User->>Application: Request for functionality
    Application->>CometBFT: Use updated dependency (v0.38.11)
    CometBFT-->>Application: Return results
    Application-->>User: Provide response

Poem

🐇 In a world of code, bright and new,
A hop and a skip, oh what a view!
With CometBFT's latest, we dance with glee,
Version eleven, oh joyfully!
Dependencies tidy, our project will soar,
Hopping through changes, we’ll code evermore! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
SpicyLemon commented 3 months ago

@dependabot recreate

SpicyLemon commented 3 months ago

I had to fix the TestConfigCmdGet test which failed because the CometBFT library was bumped, giving the version config field a new default. For the most part, that test checks the config against a pre-defined set of default values. But since that specific field has caused problems a few times now, I updated that test to get the value and make sure its got the expected format, rather than having it hard-coded.