Closed dependabot[bot] closed 1 month ago
[!IMPORTANT]
Review skipped
Bot user detected.
To trigger a single review, invoke the
@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Ugh... Breaking 3rd party protobuf change due to the bump in ics23/go
.
Error: Enum value "3" on enum "HashOp" changed name from "KECCAK" to "KECCAK256".
Error: buf found 1 breaking changes.
I'm not sure what we can do about that, so I'm gonna hold off on this PR for a bit.
There's a good chance that we just accept it and move forward, but we need to consider the ramifications first.
Created https://github.com/cosmos/ics23/issues/376 to let them know about the breaking change. We'll wait on that a bit before deciding what to do here.
Two things combine to make it very likely that this won't cause a problem:
KECCAK
yet.Also, there isn't really a way to fix this since the updated proto is already out there; changing it back would cause another breaking change for anyone using this version.
So we really only have two options:
Option 1 seems like the only realistic option to me, so I suggest we approve and merge this PR.
Bumps cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5.
Commits
25255e4
feat(client/v2): use x/txAminoNameAsTypeURL
option in 0.50 (#21801)7ee3115
feat(x/tx): addaminoNameAsTypeURL
option in aminojson encoder (backport #2...f812291
chore: prepare v0.50.10 (#21498)b2ec2f6
fix(runtime): fix option order (backport #21769) (#21771)9a0a76f
docs(x/circuit): display correct example (backport #21768) (#21773)3feb2c0
docs: demonstrate how to wire custom ante handlers in 0.50 app_di (#21767)b21441c
feat(types/collections): addLegacyDec
collection value (backport #21693) (...f78ed49
feat(x/genutil): add better error messages for genesis validation (backport #...fe37dfb
docs(x/authz): update grant docs (backport #21677) (#21700)ef8a575
docs(client/debug): correctdebug raw-bytes
command example (backport #2167...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show