search

proversity-org / edx-platform

The Open edX platform, the software that powers edX!
http://open.edx.org/
GNU Affero General Public License v3.0
1 stars 1 forks source link

PE-275 - Add custom reports api djangoapp #1040

Closed ericfab179 closed 4 years ago

ericfab179 commented 5 years ago

This PR adds the djangoapp "custom_reports" developed by Zeus Learning for edx-platform.

ryangadams commented 5 years ago

Should the custom_reports be a separate git repo that we include into edx-platform via pip (or some other approach)? I'm thinking about our future plans to migrate to Hawthorn/Ironwood/Juniper

ericfab179 commented 5 years ago

Should the custom_reports be a separate git repo that we include into edx-platform via pip (or some other approach)? I'm thinking about our future plans to migrate to Hawthorn/Ironwood/Juniper

@ryangadams Yes maybe another approach is better. @andrey-canon could it be a pulgin ?

andrey-canon commented 5 years ago

Should the custom_reports be a separate git repo that we include into edx-platform via pip (or some other approach)? I'm thinking about our future plans to migrate to Hawthorn/Ironwood/Juniper

@ryangadams Yes maybe another approach is better. @andrey-canon could it be a pulgin ?

@ryangadams @ericfab179 yeah, this should be a plugin in order to make the migrations easier, but first we should test if the plugins works right on this platform version and then re-factor the app.

ryangadams commented 5 years ago

Ok, here's what I'm going to ask Zeus to change and re-submit:

  1. rename djangoapp from proversity to proversity_custom_reports (different from what we've got here but better I think)
  2. write the report to S3 instead of application server disk
  3. extract TOTAL_THREADS_IN_WEEKLY_REPORT and ENABLE_THREADING_IN_RG to settings with 5 and true as default values

I'm not going to request shifting to celery or a plugin, but we might need to consider that approach in future.