search

provinzio / CoinTaxman

Calculate your taxes from cryptocurrency gains
GNU Affero General Public License v3.0
143 stars 31 forks source link

Transfers between Coinbase and Coinbase Pro not considered #138

Open jhoogstraat opened 2 years ago

jhoogstraat commented 2 years ago

The reports from Coinbase and Coinbase Pro do not explicitly state transfers between the two. In case of MULTI_DEPOT being enabled, this leads to missing coins on either side.

I am unsure whether the two can be considered as distinct exchanges at all. This hints at that they are not.

Edit: Just saw that the Account statement on Coinbase Pro does include deposits and withdrawals. I think we should use that instead of the Fills statement. Doesn't fix the issue on the Coinbase side though.

provinzio commented 2 years ago

When the information if the withdrawal/deposit is missing think the statement files we have to count them as the same wallet...

jhoogstraat commented 2 years ago

If that is allowed by our tax laws. They are technically two separate wallets.

provinzio commented 2 years ago

If that is allowed by our tax laws. They are technically two separate wallets.

I cannot confirm that, but if we are unable to reconstruct the deposit/withdraw between coinbase and coinbase pro, we have no choice. Maybe check that again or write an email to the Coinbase support?

jhoogstraat commented 2 years ago

Their support site says

Zu diesem Zeitpunkt müssen internationale Kunden ihre internationalen Steuerpflichten anhand ihres Transaktionsverlaufs ermitteln. Wir können keine zusätzlichen Informationen bereitstellen und keine lokal erforderlichen Formulare in Ihrem Namen einreichen. Wir empfehlen Ihnen, die Hilfe eines Steuerberaters in Ihrer Nähe anzufordern.

I mailed then still.. lets see.

Another thing: Coinbase lets you buy coins directly with fiat without depositing them first. So in case of Coinbase we should count buys with fiat as deposit+trade (resolves missing fiat warning).

provinzio commented 2 years ago

But it doesn't have do be deposit+trade? Or is it always deposit+trade? In that case it's possible and necessary

jhoogstraat commented 2 years ago

Today, you actually can. I am unsure whether you could always deposit fiat.

I am unsure how to distinguish buys with deposited money or direct buy. Discussion is continued here #139

provinzio commented 2 years ago

Regarding the transfers between coinbase and coinbase pro:

Although your Coinbase and Coinbase Pro accounts are linked, they have their own separate wallets. Transfers from Coinbase to Coinbase Pro are free.

Coinbase and coinbase pro are separeted wallets. See https://help.coinbase.com/en/pro/managing-my-account/funding-your-account/how-to-transfer-funds-between-your-coinbase-pro-and-coinbase-accounts

Just saw that the Account statement on Coinbase Pro does include deposits and withdrawals. I think we should use that instead of the Fills statement. Doesn't fix the issue on the Coinbase side though.

You mentioned, that you found a file which includes the deposits between these to. Please implement it or raise an error when it's missing, but the user selected MULTI_METHOD.