search

provinzio / CoinTaxman

Calculate your taxes from cryptocurrency gains
GNU Affero General Public License v3.0
140 stars 31 forks source link

Add deposit when buying with fiat #139

Open jhoogstraat opened 2 years ago

jhoogstraat commented 2 years ago

This adds a deposit operation when buying coins with fiat on coinbase. Also sets the platform from "coinbase_pro" to "coinbase" to remove issue regarding transfers between the two.

Tracking issue: #138

provinzio commented 2 years ago

When it's possible to buy with fiat without depositing it before (see your comment in #138), we shouldn't implement it like that.

A warning might be ok in that case which could disable the deposit/withdrawal page in the export.

jhoogstraat commented 2 years ago

Then you get a warning that you basically can do nothing about. Maybe later on we can add a interaction where the user confirms that a buy should create a deposit as well. Or have in another file.

provinzio commented 2 years ago

Good points! Or disable the deposit/withdrawal export as long as only the home fiat got deposited. In that case it's not necessary for the tax evaluation.