Closed jhoogstraat closed 2 years ago
I think it is enough, if requirements-dev.in
references requirements.in
(which adds all deps in requirements.txt
to requirements-dev.txt
). I can create a requirements-base.in
, but in my opinion that only adds complexity and does make it ambiguous where to put new dependencies.
I think it is enough, if
requirements-dev.in
referencesrequirements.in
(which adds all deps inrequirements.txt
torequirements-dev.txt
). I can create arequirements-base.in
, but in my opinion that only adds complexity and does make it ambiguous where to put new dependencies.
Referencing sounds like a good idea.
The dev deps are now constrained torequirements.txt
and do not include normal deps anymore.
This is because there were unresolvable dependencies (pointing to different versions) in each file.
I don't really like having requirements-dev.in
depend on requirements.txt
, but yeah..
The dev deps are now constrained to
requirements.txt
and do not include normal deps anymore. This is because there were unresolvable dependencies (pointing to different versions) in each file.I don't really like having
requirements-dev.in
depend onrequirements.txt
, but yeah..
But it should be contrainted by the base requirements, shouldn't it? The dev reqs are always installed with the base reqs. It doesn't make sense to install dev reqs by themselves.
The dev deps are now constrained to
requirements.txt
and do not include normal deps anymore. This is because there were unresolvable dependencies (pointing to different versions) in each file. I don't really like havingrequirements-dev.in
depend onrequirements.txt
, but yeah..But it should be contrainted by the base requirements, shouldn't it? The dev reqs are always installed with the base reqs. It doesn't make sense to install dev reqs by themselves.
Sorry for the misunderstanding. The dev reqs are constrained by the base reqs. It's just that they are not duplicated in the -dev.txt
file. The make command and the ci action are doing the same, installing the base reqs and then the dev reqs.
The dev deps are now constrained to
requirements.txt
and do not include normal deps anymore. This is because there were unresolvable dependencies (pointing to different versions) in each file. I don't really like havingrequirements-dev.in
depend onrequirements.txt
, but yeah..But it should be contrainted by the base requirements, shouldn't it? The dev reqs are always installed with the base reqs. It doesn't make sense to install dev reqs by themselves.
Sorry for the misunderstanding. The dev reqs are constrained by the base reqs. It's just that they are not duplicated in the
-dev.txt
file. The make command and the ci action are doing the same, installing the base reqs and then the dev reqs.
In that case, we can adjust the make routine for installing the dev requirements.
But I am indifferent whether we constrain the requirements or include them... we can keep it like now; fine for me.
Maybe add 1-2 lines to explain how to use pip-tools in the readme?
Do you have a good idea, what we could say in the readme? Looking forward to your commit.
Hey @jhoogstraat, thank you for your awesome contribution. This really cleans up our dependencies.
This is a follow-up pr for #122.
Maybe add 1-2 lines to explain how to use pip-tools in the readme?
I tried to fix linting issues as good as I can. Please review.