search

provinzio / CoinTaxman

Calculate your taxes from cryptocurrency gains
GNU Affero General Public License v3.0
141 stars 31 forks source link

Bitpanda Exchange changed the format of their Trades export CSV #79

Closed uvok closed 2 years ago

uvok commented 2 years ago

Bitpanda added a "BEST_EUR Rate" column to their CSV export.

Currently, the assertion book.py:551 fails because of that,

What would be the best course? Change the code so that both CSV versions can be read? What would be the ideal changes for that?

The pro of this change is that I don't have to to the weird candlestick querying for BEST_EUR price anymore if the column is present.

uvok commented 2 years ago

Specifically, how can you handle "optional" columns in the for (column1, column2, column3) in reader loop?

uvok commented 2 years ago

Seems I can workaround with this: https://www.python.org/dev/peps/pep-3132/

uvok commented 2 years ago

Fixed with Pull Request