TKL is not compatible with Anope 2.0.x

[strlcat]

TKL command takes nine arguments whilst Anope 2.0.x with unreal4 protocol module knows only about 8. The result is that Q TKLs for example are never enforced, as well as TKL content is interpreted wrong.

[Y4kuzi]

I pushed some fixes in m_tkl module. For me, Q:line works fine with Anope 2.0.11.

Anope logs:

[Sep 04 22:11:12.000298 2024] Debug: Received: @msgid=cce1d8046af911ef8316;dev.provisionweb.org/oper=netadmin;time=2024-09-04T20:10:58.659Z;account=Sirius :032AAAB PRIVMSG 00BAAAAAH :sqline add +0 testnick This nick has been banned [Sep 04 22:11:12.000300 2024] Debug: Sent: :00B SQLINE testnick :[Sirius] This nick has been banned (ID: FS3A066KB5) [Sep 04 22:11:12.000300 2024] Debug: Sent: :00BAAAAAH NOTICE 032AAAB :testnick added to the SQLINE list. [Sep 04 22:11:12.000300 2024] ADMIN: Sirius!provision@Lenovo (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)] [Sep 04 22:11:12.000301 2024] Debug: Sent: :00B SENDUMODE o :from OperServ: ADMIN: Sirius!provision@Lenovo (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)]

Client logs:

[22:11:12] -> Server: privmsg OperServ sqline add +0 testnick This nick has been banned [22:11:12] -services.dev.provisionweb.org- [info] (tkl) Global Q:Line active for testnick by services.dev.provisionweb.org [[Sirius] This nick has been banned (ID: FS3A066KB5)] expires on: never [22:11:12] -OperServ- testnick added to the SQLINE list. [22:11:12] -services.dev.provisionweb.org- from OperServ: ADMIN: Sirius!provision@Lenovo (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)] [22:11:15] -dev.provisionweb.org- Q:Line Rejection -- Forbidden nick testnick from client 127.0.0.1 [Current nick: wtf]

If you still have issues after pulling the latest changes, can you provide some logs so I can see what's going on?

[strlcat]

I will take a look at this today after my workday, thank you for verbose explanation.

4 сентября 2024 г. 20:22:40 UTC, Y4kuzi @.***> пишет:

I pushed some fixes in m_tkl module. For me, Q:line works fine with Anope 2.0.11.

Anope logs:

[Sep 04 22:11:12.000298 2024] Debug: Received: @msgid=cce1d8046af911ef8316;dev.provisionweb.org/oper=netadmin;time=2024-09-04T20:10:58.659Z;account=Sirius :032AAAB PRIVMSG 00BAAAAAH :sqline add +0 testnick This nick has been banned [Sep 04 22:11:12.000300 2024] Debug: Sent: :00B SQLINE testnick :[Sirius] This nick has been banned (ID: FS3A066KB5) [Sep 04 22:11:12.000300 2024] Debug: Sent: :00BAAAAAH NOTICE 032AAAB :testnick added to the SQLINE list. [Sep 04 22:11:12.000300 2024] ADMIN: @. (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)] [Sep 04 22:11:12.000301 2024] Debug: Sent: :00B SENDUMODE o :from OperServ: ADMIN: @. (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)]

Client logs:

[22:11:12] -> Server: privmsg OperServ sqline add +0 testnick This nick has been banned [22:11:12] -services.dev.provisionweb.org- [info] (tkl) Global Q:Line active for testnick by services.dev.provisionweb.org [[Sirius] This nick has been banned (ID: FS3A066KB5)] expires on: never [22:11:12] -OperServ- testnick added to the SQLINE list. [22:11:12] -services.dev.provisionweb.org- from OperServ: ADMIN: @. (Sirius) used SQLINE on testnick ([Sirius] This nick has been banned), expires in never [affects 0 user(s) (0%)] [22:11:15] -dev.provisionweb.org- *** Q:Line Rejection -- Forbidden nick testnick from client 127.0.0.1 [Current nick: wtf]

If you still have issues after pulling the latest changes, can you provide some logs so I can see what's going on?

-- Reply to this email directly or view it on GitHub: https://github.com/provisionircd/ProvisionIRCd/issues/15#issuecomment-2329901938 You are receiving this because you authored the thread.

Message ID: @.***>