proway2 / go-igrf

Pure Go IGRF (International Geomagnetic Reference Field) implementation.
MIT License
6 stars 0 forks source link

Check `findDateFactor` function. #13

Closed proway2 closed 2 years ago

proway2 commented 2 years ago

When date is higher than end_epoch the factor is calculated the very same way it's done in C implementation. However, this calculation doesn't respect leap years, although when date is lower than end_epoch, factor is calculated with respect to leap years.

Check if it's possible to improve accuracy by calculating factor with leap years when date is higher than end_epoch.

proway2 commented 2 years ago

There is no practical need to calculate the factor with respect to leap years in case when date is higher than end_epoch. The reason behind that is that this is only used to calculate the factor for SV values only. These values (SV) are rather coarse, so there is no reason to make calculations more accurate because it won't affect the overall accuracy.