upgrade to persistent 2.5

prowdsponsor / esqueleto

Bare bones, type-safe EDSL for SQL queries on persistent backends.

http://hackage.haskell.org/package/esqueleto

BSD 3-Clause "New" or "Revised" License

177 stars 51 forks source link

upgrade to persistent 2.5 #139

Closed hlian closed 7 years ago

hlian commented 8 years ago

Persistent 2.5 introduces a backwards-incompatible change with how backends are constrained. I wasn't sure how y'all wanted to deal with this (-XCPP?), but this patch does the dumb thing by yanking the lower bound in esqueleto.cabal to persistent >= 2.5 && < 2.6.

issue #137

pseudonom commented 8 years ago

We should probably try to combine these two? https://github.com/prowdsponsor/esqueleto/pull/134

hlian commented 8 years ago

👍 i'll wait for #134 to land and then rebase?

tebello-thejane commented 7 years ago

base is still constrained to < 4.9, so this won't build on GHC8.

Is this on purpose?

pseudonom commented 7 years ago

I think https://github.com/prowdsponsor/esqueleto/pull/144 is the preferred version of this PR.

hlian commented 7 years ago

yep!