search

prowdsponsor / esqueleto

Bare bones, type-safe EDSL for SQL queries on persistent backends.
http://hackage.haskell.org/package/esqueleto
BSD 3-Clause "New" or "Revised" License
178 stars 51 forks source link

Fix for #74 #75

Closed snoyberg closed 10 years ago

snoyberg commented 10 years ago

Hold on, tests are failing...

snoyberg commented 10 years ago

@gregwebs I think this is a bug in persistent, the PersonId constructor does not seem to have an id associated with it.

snoyberg commented 10 years ago

OK, I've pushed a fix to persistent-template and released it to Hackage. This pull request does in fact fix esqueleto, and can be merged/released when you're ready @meteficha.

meteficha commented 10 years ago

I'm not sure I understand what is the best course of action from reading your and @gregwebs' messages.

  1. Should I bump the dependency on persistent-template?
  2. Should I release it now or wait for persistent-2.1?
gregwebs commented 10 years ago

You should go ahead and bump the persistent-template dependency and release since esqueleto-2.0 is already on hackage. When 2.1 is released you should release again and put that as the lower bounds.

meteficha commented 10 years ago

Released as esqueleto-2.0.1. Thanks!

snoyberg commented 10 years ago

Thanks Felipe!