Closed jfagoagas closed 1 week ago
Tested locally and it perfectly works!
Attention: Patch coverage is 74.09326%
with 50 lines
in your changes missing coverage. Please review.
Project coverage is 87.39%. Comparing base (
2345a73
) to head (c7e9264
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now, batch_send_to_security_hub
use _send_findings_to_security_hub
passing the findings as a dict and the finding format in AWSSecurityFindingFormat
. The real problem it's that resolve_security_hub_previous_findings
pass the findings in dict function. I've made a "parse" in _send_findings_to_security_hub
and depending the data structure it makes a different behaviour. This is not correct so I'll work on standardize all
The final approach it's that all the findings passed to _send_findings_to_security_hub
are dict
Context
We are creating modular outputs for Prowler, now is the time for the AWS Security Finding Format.
Description
ASFF(Output)
class.filter_security_hub_findings_per_region
since now we don't need to recreate the ASFF findings, we've been doing it twice 🤦License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.