feat(aws): Split the checks that mix RDS Instances and Clusters

prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more

Apache License 2.0

10.53k stars 1.51k forks source link

Context

There were two checks labeled as instance checks that were scanning both instances and clusters. That's why I have separated these into different checks to enhance the scanning process.

These two checks have something in common: they are "heritable." If a cluster has a certain attribute, then the instances that belong to it will have the same attribute. That's why in the instance checks, we only scan instances that are not part of a cluster.

Additionally, in the IAM authentication check, some engines do not support this type of authentication, so I have decided not to include those in the scan.

Description

I added rds_cluster_iam_authentication, rds_cluster_default_admin both with its respective unit tests and modified rds_instance_iam_authentication and rds_instance_default_admin

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.10%. Comparing base (cb807e4) to head (dc071cb).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4730 +/- ## ========================================== + Coverage 89.06% 89.10% +0.03% ========================================== Files 914 916 +2 Lines 27970 27984 +14 ========================================== + Hits 24912 24934 +22 + Misses 3058 3050 -8 ```

prowler-cloud / prowler