Closed MarioRgzLpz closed 2 months ago
Attention: Patch coverage is 89.36170%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 89.05%. Comparing base (
e11bb47
) to head (d366bc1
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...roject_source_repo_url_no_sensitive_credentials.py | 84.37% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please name the check codebuild_project_source_repo_url_no_sensitive_credentials
and create a BaseModel called Source to fill it with the information needed.
@sergargar All the changes requested done in commit 64bade9.
Context
To improve security and adhere to best practices for code repository management, we are adding a new check within the CodeBuild framework. This check ensures that source repository URLs (right now only Bitbucket) do not contain sensitive credentials like authentication tokens or username and password.
Description
I added
codebuild_bitbucket_urls_no_sensitive_credentials
check with respective unit tests. In order to that I modifiedcodebuild_service.py
to add two new attributessource
secondary_sources
to theProject
model, a new modelSource
and added respective test tocodebuild_service_test.py
.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.