refactor(s3): Changed buckets variable type form list to dict

prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more

https://prowler.com

Apache License 2.0

10.53k stars 1.51k forks source link

refactor(s3): Changed buckets variable type form list to dict #4742

Closed HugoPBrito closed 4 weeks ago

HugoPBrito commented 4 weeks ago

Description

To improve consistency and future code utility, the variable buckets in S3 service has been changed from list to dict.

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.10%. Comparing base (52d83bd) to head (201908a). Report is 4 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4742 +/- ## ========================================== + Coverage 89.07% 89.10% +0.03% ========================================== Files 918 920 +2 Lines 28088 28125 +37 ========================================== + Hits 25019 25062 +43 + Misses 3069 3063 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.