prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more
https://prowler.com
Apache License 2.0
10.53k stars 1.51k forks source link

feat(ec2): Client VPN Endpoints Should Have Client Connection Logging Enabled #4804

Closed MarioRgzLpz closed 3 weeks ago

MarioRgzLpz commented 3 weeks ago

Context

Ensure Client VPN endpoints have client connection logging enabled. The control fails if logging is not enabled for the endpoint. Client connection logs are crucial for tracking user activity and ensuring visibility into VPN usage.

Enabling connection logging helps in monitoring, auditing, and troubleshooting VPN connections, contributing to overall security and compliance.

Description

I added ec2_client_vpn_endpoint_connection_logging_enabled check with respective unit tests. In order to that I modified ec2_service.py to add a new model VpnEndpoint and added respective test to ec2_service_test.py.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.17%. Comparing base (ff24413) to head (489e7be). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4804 +/- ## ========================================== + Coverage 89.11% 89.17% +0.05% ========================================== Files 928 929 +1 Lines 28428 28463 +35 ========================================== + Hits 25335 25381 +46 + Misses 3093 3082 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MarioRgzLpz commented 3 weeks ago

@sergargar Status extended changes done in commit 588971b