codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
Project coverage is 89.04%. Comparing base (
0c7b960) to head (2568f4f). Report is 2 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...enabled/rds_instance_iam_authentication_enabled.py | 83.33% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #4827 +/- ## ========================================== - Coverage 89.06% 89.04% -0.02% ========================================== Files 926 926 Lines 28365 28376 +11 ========================================== + Hits 25262 25267 +5 - Misses 3103 3109 +6 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
We have decided to modify the checks for RDS instances that inherit settings from their clusters. For example, if
iam authenticationis enabled at the cluster level but not at the instance level, the cluster setting will prevail, and the instance will have this setting on. Previously, these checks only scanned unclustered instances because the cluster checks covered any clustered instances. However, it's not ideal to have no findings when scanning instances, even if the cluster check covers them. The new approach is to adjust these checks so that they provide findings indicating whether a pass or fail result comes from an unclustered instance or is inherited from the cluster level.Description
Modified checks
rds_instance_iam_authentication_enabledandrds_instance_default_adminwith their unit tests.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.