feat(elb): add new check `elb_is_in_multiple_az`

prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more

https://prowler.com

Apache License 2.0

10.53k stars 1.51k forks source link

feat(elb): add new check `elb_is_in_multiple_az` #4829

Closed puchy22 closed 2 weeks ago

puchy22 commented 3 weeks ago

Context

Checks that Classic Load Balancers are configured with registered instances from at least the specified number of Availability Zones (AZs). The control fails if the load balancer does not span the minimum number of AZs specified.

Description

[x] Modify service to add AZs to ELB
[x] Test service changes
[x] Add configurable parameter for the check
[x] Add check logic
[x] Add unit testing for the check

Checklist

Are there new checks included in this PR? Yes
- If so, do we need to update permissions for the provider? No.
[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.18%. Comparing base (79f1cf8) to head (b43d575). Report is 5 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4829 +/- ## ========================================== + Coverage 89.15% 89.18% +0.03% ========================================== Files 935 936 +1 Lines 28591 28614 +23 ========================================== + Hits 25489 25520 +31 + Misses 3102 3094 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.