chore(test): improve `iam_root_hardware_mfa_enabled` tests

prowler-cloud / prowler

Prowler is an Open Source Security tool for AWS, Azure, GCP and Kubernetes to do security assessments, audits, incident response, compliance, continuous monitoring, hardening and forensics readiness. Includes CIS, NIST 800, NIST CSF, CISA, FedRAMP, PCI-DSS, GDPR, HIPAA, FFIEC, SOC2, GXP, Well-Architected Security, ENS and more

https://prowler.com

Apache License 2.0

10.53k stars 1.51k forks source link

chore(test): improve `iam_root_hardware_mfa_enabled` tests #4833

Closed sergargar closed 3 weeks ago

sergargar commented 3 weeks ago

Description

Improve iam_root_hardware_mfa_enabled tests by removing search and adding asserts.

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
[ ] Review if the code is being covered by tests.
[ ] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.15%. Comparing base (5f075b2) to head (1db3a3f). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4833 +/- ## ========================================== + Coverage 89.11% 89.15% +0.04% ========================================== Files 926 926 Lines 28365 28365 ========================================== + Hits 25277 25289 +12 + Misses 3088 3076 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

💚 All backports created successfully

Status	Branch	Result
✅	v3
✅	v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details