Closed MarioRgzLpz closed 1 month ago
@sergargar Requested changes added in commit 2abc66e
Something is broken in a type definition, I think in this line public_ip_addresses: list[IPv4Address | IPv6Address]
.
Attention: Patch coverage is 76.74419%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 88.87%. Comparing base (
39e8485
) to head (bfb0eb3
). Report is 1 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
prowler/providers/aws/services/ec2/ec2_service.py | 75.00% | 10 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
While trying to do a new check I noticed that in
__get_launch_template_versions__
(now__describe_launch_template_version
) method we were saving a big dictionary with a lot of data inLaunchTemplateVersion
that we were not using later. To follow good practices I will change the service creating a new ModelTemplateData
in which we will save only the things we need to do the checks. This will lead to a change inec2_launch_template_no_secrets
check that is currently using thetemplate_data
and some adjustments on the service tests and check tests.Description
I had to change the
ec2_service
addingTemplateData
model and adding only two attributesuser_data
for the secrets check andassociate_public_address
for a new check. This lead to a change in theec2_service_test
and some changes in theec2_launch_template_no_secrets
check and his test.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.